[alsa-devel] [PATCH v3 3/6] ASoC: WM8903: Pass pdata to wm8903_init_gpio

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Dec 2 01:27:33 CET 2011

On Thu, Dec 01, 2011 at 01:49:21PM -0700, Stephen Warren wrote:

> -	if (pdata && pdata->gpio_base)
> -		wm8903->gpio_chip.base = pdata->gpio_base;
> -	else
> -		wm8903->gpio_chip.base = -1;
> +	wm8903->gpio_chip.base = pdata->gpio_base;

This will break existing users in counjuntion with the previous patch.
Previously if the user provided platform data but left gpio_base as zero
we'd use -1 and let gpiolib pick for us.  Now instead the driver will
take that zero and pass it on to gpiolib, probably failing as the SoC
will have taken the low numbered GPIOs.

More information about the Alsa-devel mailing list