[alsa-devel] [PATCH 1/1] ASoC: soc-core: check rate for symmetry only when pcm is ongoing
broonie at opensource.wolfsonmicro.com
Wed Aug 24 11:19:03 CEST 2011
On Wed, Aug 24, 2011 at 03:57:20PM +0800, Dong Aisheng wrote:
> Now we only check rate for symmetry when the pcm is really ongoing
> which seems more sensible.
There's a genuine issue here due to the raciness of the ALSA APIs -
we're not enforcing constraints and we should be. If the two programs
end up setting incompatible rates we need to handle that.
> /* Symmetry data - only valid if symmetry is being enforced */
> unsigned int rate;
> + unsigned int ongoing;
This isn't a clear name, I don't understand it.
> @@ -209,6 +212,7 @@ static int soc_pcm_open(struct snd_pcm_substream *substream)
> + rtd->ongoing = 1;
> return 0;
> @@ -322,6 +326,7 @@ static int soc_pcm_close(struct snd_pcm_substream *substream)
> + rtd->ongoing = 0;
What happens when the stream in one direction is stopped but not the
other? For example, capture stops but playback continues.
More information about the Alsa-devel