[alsa-devel] [PATCH v2 0/2] ASoC: omap-mcpdm: New McPDM driver

Peter Ujfalusi peter.ujfalusi at ti.com
Fri Aug 19 09:41:17 CEST 2011

Hello Mark, Liam,

I tried to address the comments regarding to version 1 of the new McPDM driver:

The omap hwmod conversion part of the v1 series has been sent as part of the
fixup series for 3.1 to make basic audio work out of box.

This series is aimed for 3.2 due to the scale of the change.
I tried to split patch 2, but I did not managed to find an incremental path from
the old driver to the new one.

I have updated the commit message for patch 2 to explain the reasoning behind
the rewritten driver, so it can be easily looked up.

Notable changes since v1:
- delayed_work from the new driver has been removed, and replaced with a
  DAPM_SUPPLY widget. This widget need to be connected to DAC/ADC of the codec
  by the machine driver in order to have the correct sequence for power off.
The first patch adds private_data pointer for dapm widgets. This private_data
can be used to add widget specific data to any widget. I think this can be handy
for others as well in the future.

- Full duplex audio in legacy mode has been fixed, so we can run arecord | aplay

This series depends on the McPDM fixup patches:


PS: to make the review easier, I have asked git format-patch to treat the change
as rewrite.

Misael Lopez Cruz (1):
  ASoC: omap-mcpdm: Replace legacy driver

Peter Ujfalusi (1):
  ASoC: DAPM: Add private data pointer for DAPM widget

 include/sound/soc-dapm.h    |    1 +
 sound/soc/omap/Makefile     |    2 +-
 sound/soc/omap/mcpdm.c      |  472 -------------------------
 sound/soc/omap/mcpdm.h      |  152 --------
 sound/soc/omap/omap-mcpdm.c |  823 ++++++++++++++++++++++++++++---------------
 sound/soc/omap/omap-mcpdm.h |   97 +++++
 sound/soc/omap/sdp4430.c    |   14 +-
 7 files changed, 656 insertions(+), 905 deletions(-)
 delete mode 100644 sound/soc/omap/mcpdm.c
 delete mode 100644 sound/soc/omap/mcpdm.h
 rewrite sound/soc/omap/omap-mcpdm.c (46%)
 create mode 100644 sound/soc/omap/omap-mcpdm.h


More information about the Alsa-devel mailing list