[alsa-devel] [PATCH] ASoC: soc-core: Fix checking return value of debugfs_create_dir

Mark Brown broonie at opensource.wolfsonmicro.com
Sun Aug 14 06:28:28 CEST 2011

On Sun, Aug 14, 2011 at 11:23:13AM +0800, Axel Lin wrote:
> We have CONFIG_DEBUG_FS guard around the place calling debugfs_create_dir,
> thus debugfs_create_dir returns NULL on failure.

On the other hand the existing code doesn't actually have any problem,
the IS_ERR() won't give false positives, so the changelog isn't really
accurate and if anything we'll introduce a bug if someone cut'n'pastes
the code elsewhere.

More information about the Alsa-devel mailing list