[alsa-devel] [PATCH] ASoC: Add device tree binding for WM8753

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Aug 10 08:30:25 CEST 2011


On Wed, Aug 10, 2011 at 01:57:11PM +0800, Barry Song wrote:
> 2011/8/10 Mark Brown <broonie at opensource.wolfsonmicro.com>:

> >>  struct ads7846_platform_data {
> >>         u16     model;                  /* 7843, 7845, 7846, 7873. */
> >>         u16     vref_mv;                /* external vref value, milliVolts
> >>                                          * ads7846: if 0, use internal vref */

> > There's some callbacks but the bulk of the structure (including the bits
> > I quoted above for example) looks like it's pure data and could sensibly
> > be represented in the device tree.

> there have been many discussions about what should be in dts.
> basically, hardware information should be in dts, but data required by
> driver implementation should be not in dts.
> There are a lot of fields in the structure, not all can be a property
> as hardware information in dts. That means the driver need a lot of
> changes then.

Things like the fields quoted above seem like they're fixed hardware
properties that oguht to be in the device tree, though.


More information about the Alsa-devel mailing list