[alsa-devel] [PATCH] ASoC: JZ4740: Fix i2s shutdown

Lars-Peter Clausen lars at metafoo.de
Sat Apr 30 22:28:20 CEST 2011

The i2s shutdown callback has the check whether it should be disabled reversed.
Currently it is disabled if another stream is still active, but kept enabled if
the last stream is closed. This patch fixes it.

Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
 sound/soc/jz4740/jz4740-i2s.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740-i2s.c
index 419bf4f..cd22a54 100644
--- a/sound/soc/jz4740/jz4740-i2s.c
+++ b/sound/soc/jz4740/jz4740-i2s.c
@@ -133,7 +133,7 @@ static void jz4740_i2s_shutdown(struct snd_pcm_substream *substream,
 	struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
 	uint32_t conf;
-	if (!dai->active)
+	if (dai->active)
 	conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);

More information about the Alsa-devel mailing list