[alsa-devel] [PATCH 2/7] ASoC: DAPM: Pass snd_dapm_soc_update as parameter

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Apr 29 00:48:17 CEST 2011


On Fri, Apr 29, 2011 at 12:34:11AM +0200, Lars-Peter Clausen wrote:

> If we'd keep the update in the dapm context we'd have to iterate over all
> contexts to find the one context which contains the update.
> As you've said we have to walk the whole graph and it does not make a nice
> interface if the function takes one specific dapm context while it works on the
> whole card.

So that's part of a separate refactoring and only applies if we're not
running DAPM in a particular context and should be something along the
lines of "now we pass the card in it's much more sensible to..."; I'm
writing this while looking at current code.

> Currently we get the codec from the widget for which the update is run and not
> from the dapm context anyway.

That's just a redundancy in the data structure; the codec and context
are just two different ways of getting to the same thing.


More information about the Alsa-devel mailing list