[alsa-devel] [PATCH 7/7] ASoC: Instantiate all DAPM widgets at once

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Apr 28 23:18:30 CEST 2011

On Thu, Apr 28, 2011 at 10:25:05PM +0200, Lars-Peter Clausen wrote:
> On 04/28/2011 10:07 PM, Mark Brown wrote:

> > ...we can still instantiate widgets at any time, and lots of code will
> > do just that (and needs to do that because it needs the widgets to be
> > present in order to allow paths to be added).

> ... there are exactly 5 codec drivers which call snd_soc_dapm_new_widgets, all
> of them call this at the end of their codec probe callback, which means it can
> be dropped, because the core will call it again just right after the codecs
> probe callback (without this patch).

So it'd seem more sensible to do that, especially if that's what the
changelog says that the change does...  Reading the change the thing
that jumps out is that it's mostly a half done function rename rather
than the change it was described as being.

> Routes can be added just fine without the widgets being instantiated. In fact
> snd_soc_dapm_new_widgets requires the routes to be setup to initialize some
> widgets(mixers,muxs) properly.

Meh, right - wrong way round.

More information about the Alsa-devel mailing list