[alsa-devel] [PATCH 4/7] ASoC: Pass snd_soc_card instead of snd_soc_dapm_context were appropriate

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Apr 28 22:13:04 CEST 2011


On Thu, Apr 28, 2011 at 08:47:57PM +0100, Mark Brown wrote:
> On Thu, Apr 28, 2011 at 06:46:10PM +0200, Lars-Peter Clausen wrote:

> >  int snd_soc_dapm_sync(struct snd_soc_dapm_context *dapm)
> >  {
> > -	return dapm_power_widgets(dapm, SND_SOC_DAPM_STREAM_NOP, NULL);
> > +	return dapm_power_widgets(dapm->card, SND_SOC_DAPM_STREAM_NOP, NULL);
> >  }
> >  EXPORT_SYMBOL_GPL(snd_soc_dapm_sync);

> This should really just operate on the card, syncing an isolated DAPM
> context is meaningless.  I'll just go do that...

On second thoughts while that's obviously the case almost no context
that needs to call this function has a card handy so it's just a bit
annoying for it to take a card as a parameter.  Feh.


More information about the Alsa-devel mailing list