[alsa-devel] [PATCH 4/7] ASoC: Pass snd_soc_card instead of snd_soc_dapm_context were appropriate

[Mark Brown]

On Thu, Apr 28, 2011 at 06:46:10PM +0200, Lars-Peter Clausen wrote:

>  	if (w->event && (w->event_flags & event)) {
> -		pop_dbg(dapm->dev, card->pop_time, "pop test : %s %s\n",
> +		pop_dbg(card->dev, card->pop_time, "pop test : %s %s\n",

This isn't a good change - logging the widgets with the card device
rather than the device of the widget isn't going to clarify things.

> -	pop_dbg(dapm->dev, card->pop_time,
> +	pop_dbg(card->dev, card->pop_time,
>  		"DAPM sequencing finished, waiting %dms\n", card->pop_time);

It's fine here because this is the system-wide sequencing that's
terminated.

>  int snd_soc_dapm_sync(struct snd_soc_dapm_context *dapm)
>  {
> -	return dapm_power_widgets(dapm, SND_SOC_DAPM_STREAM_NOP, NULL);
> +	return dapm_power_widgets(dapm->card, SND_SOC_DAPM_STREAM_NOP, NULL);
>  }
>  EXPORT_SYMBOL_GPL(snd_soc_dapm_sync);

This should really just operate on the card, syncing an isolated DAPM
context is meaningless.  I'll just go do that...

Otherwise these look good.