[alsa-devel] [PATCH] - ALSA hda ad1988 - Add Independent HP Switch to model 6stack-dig-fp
tiwai at suse.de
Tue Apr 26 12:32:57 CEST 2011
At Tue, 19 Apr 2011 08:12:57 +0800,
Raymond Yau wrote:
> Add Independent HP Switch to model 6stack-dig-fp
> allow user to switch Independent HP on/off by using ALSA specific "share
> stream" mode
> This don't need to make "Headphone Playback Volume" inactive but this also
> mean that "Headphone Playback Volume" is no longer slave of the "Virtual
> Master" any more
The implementation looks almost OK (although there are a few pieces
of unused code slike activate_ctl()), I prefer an enum control for it.
It's a frequently seen problem that user sets "Independent HP" mixer
switch accidentally and gets unexpected results. An enum control
tends to be more clear than a mixer switch in general.
Could you rewrite the patch (and do a bit more clean up) and resend?
More information about the Alsa-devel