[alsa-devel] [PATCH 2/2] ASoC: Implement WM8962 DMIC support

Stephen Warren swarren at nvidia.com
Mon Apr 25 21:33:14 CEST 2011


Mark Brown wrote at Monday, April 25, 2011 1:15 PM:
>...
> --- a/sound/soc/codecs/wm8962.c
> +++ b/sound/soc/codecs/wm8962.c
> @@ -2468,6 +2468,7 @@ SND_SOC_DAPM_INPUT("IN3R"),
>  SND_SOC_DAPM_INPUT("IN4L"),
>  SND_SOC_DAPM_INPUT("IN4R"),
>  SND_SOC_DAPM_INPUT("Beep"),
> +SND_SOC_DAPM_INPUT("DMICDAT"),
> 
>  SND_SOC_DAPM_MICBIAS("MICBIAS", WM8962_PWR_MGMT_1, 1, 0),
> 
> @@ -2487,6 +2488,8 @@ SND_SOC_DAPM_MIXER("MIXINL", WM8962_PWR_MGMT_1, 5,
> 0,
>  SND_SOC_DAPM_MIXER("MIXINR", WM8962_PWR_MGMT_1, 4, 0,
>  		   mixinr, ARRAY_SIZE(mixinr)),
> 
> +SND_SOC_DAPM_AIF_IN("DMIC", NULL, 0, WM8962_PWR_MGMT_1, 10, 0),
> +

Mark,

I notice you added both a SND_SOC_DAPM_INPUT and a SND_SOC_DAPM_AIF_IN
for the DMIC path here. Should the WM8903 DMIC patch I provided have
done the same?

Thanks

-- 
nvpublic



More information about the Alsa-devel mailing list