[alsa-devel] [PATCH 1/2] ARM: EXYNOS4: Add PCM audio support for WM8994

[Jassi Brar]

On Mon, Apr 25, 2011 at 12:24 PM, Sangbeom Kim <sbkim73 at samsung.com> wrote:

> --- a/arch/arm/plat-samsung/include/plat/audio.h
> +++ b/arch/arm/plat-samsung/include/plat/audio.h
> @@ -36,6 +36,8 @@ struct samsung_i2s {
>  */
>  #define QUIRK_NO_MUXPSR                (1 << 2)
>  #define QUIRK_NEED_RSTCLR      (1 << 3)
> +/* If the PCM block has no internal prescalar or MUX */
> +#define QUIRK_NO_DIV           (1 << 4)
>        /* Quirks of the I2S controller */
>        u32 quirks;

I think the I2S and PCM configuration don't share enough.
So maybe a separate 'struct samsung_pcm' is warranted here.
Also, if new SoC PCM blocks are going to _not_ have the divider
may be it's a good idea to make that as 'norm' and having divider
as a 'quirk' ?  That way, new code wouldn't have to bother adding
the quirk every time.

-j