[alsa-devel] Tegra ASoC, multiple boards, platform data, and conditionals in machine driver

Olof Johansson olof at lixom.net
Mon Apr 11 19:57:06 CEST 2011


On Mon, Apr 11, 2011 at 8:27 AM, Stephen Warren <swarren at nvidia.com> wrote:

> Perhaps the best approach is to:
> * Keep a single machine driver (at least for Tegra+WM8903; as Mark noted,
>  attempting to share any wider doesn't make sense)
> * Rename the driver e.g. tegra_wm8903.c rather than harmony.c since it'll
>  be more generic. Rename the platform data structure and header likewise.
> * Expand the platform data structure used by that driver to add anything
>  necessary for Seaboard and derivatives.
> * Expand the driver to handle optional/missing GPIO definitions in the
>  platform data (i.e. Harmony/Ventana will fill in int/ext_mic_en, and
>  other boards will set it to -1. Only Kaen will fill in hp_mute GPIO,
>  etc.)
> That way, we can still avoid a proliferation in the number of platform
> headers, platform data types, and ASoC machine drivers.
> Does that sound like a plan?

Sounds good to me.


More information about the Alsa-devel mailing list