[alsa-devel] [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable

Takashi Iwai tiwai at suse.de
Wed Apr 6 08:06:22 CEST 2011


At Tue, 5 Apr 2011 21:35:12 -0500,
Tarek Soliman wrote:
> 
> On Mon, Apr 04, 2011 at 09:23:53AM -0500, Tarek Soliman wrote:
> > There are many USB MIDI cables out there that have buggy
> > firmware that reports it can do more than 4 bytes in a
> > packet when they can only properly handle 4
> > 
> > This patch adds the ID of yet another one of those cables
> > 
> > Signed-off-by: Tarek Soliman <tarek at bashasoliman.com>
> > ---
> >  sound/usb/midi.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/sound/usb/midi.c b/sound/usb/midi.c
> > index b4b39c0..f928910 100644
> > --- a/sound/usb/midi.c
> > +++ b/sound/usb/midi.c
> > @@ -1301,6 +1301,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
> >  	case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
> >  	case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
> >  	case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
> > +	case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
> >  		ep->max_transfer = 4;
> >  		break;
> >  		/*
> > -- 
> > 1.7.4.1
> > 
> > As instructed, I updated the insertion point of the new entry such
> > that the entries are sorted.
> 
> Hi,
> 
> Is there anything else required for this to be merged?
> I am very new to this.

Your new patch is fine.  I applied it now.
Thanks!


Takashi


More information about the Alsa-devel mailing list