[alsa-devel] [PATCH 2/3 v3] alsa-lib: fixed coverity reported issues under "RESOURCE_LEAK" checker.

Sudarshan Bisht sudarshan.bisht at nokia.com
Tue Apr 5 09:45:30 CEST 2011


On Mon, 2011-04-04 at 10:30 -0700, ext Steve Calfee wrote:
> On 04/04/11 01:53, sudarshan.bisht at nokia.com wrote:
> 
> > @@ -1847,6 +1848,7 @@ int snd_config_delete(snd_config_t *config)
> >  		list_del(&config->list);
> >  	free(config->id);
> >  	free(config);
> > +	config = NULL;	  	
> >  	return 0;
> >  }
> 
> I don't see how this could be correct. You free memory, clear the
> calling param pointing to it and then return? What is the point of
> nulling the local pointer?
yes,  this is not needed actually. 
> 
> Regards, Steve


Thanks,

-Sudarshan 



More information about the Alsa-devel mailing list