[alsa-devel] [patch 1/1] sgtl5000: Fix suspend/resume

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Apr 5 02:18:59 CEST 2011

On Mon, Apr 04, 2011 at 05:13:00PM +0200, Arnaud Patard wrote:

>  /* default value of sgtl5000 registers except DAP */
> -static const u16 sgtl5000_regs[SGTL5000_MAX_REG_OFFSET >> 1] =  {
> +static const u16 sgtl5000_regs[SGTL5000_MAX_REG_OFFSET] =  {
>  	0xa011, /* 0x0000, CHIP_ID. 11 stand for revison 17 */
> +	0,

It's not immediately obvious that this is the best fix - the driver does
declare a step of 2 so I'd expect it to be able to lay out the cahce
defaults like this.  Also, it'd be easier to review the patch if you
could split out the cache stride fix from the rest of the changes,
there's quite a few things going on in this patch.

More information about the Alsa-devel mailing list