[alsa-devel] [PATCH 1/3 v3] alsa-lib: fixed coverity reported issues under "FORWARD_NULL" checker.

Takashi Iwai tiwai at suse.de
Mon Apr 4 12:35:11 CEST 2011


At Mon, 4 Apr 2011 10:18:23 +0100,
Mark Brown wrote:
> 
> On Mon, Apr 04, 2011 at 11:53:57AM +0300, sudarshan.bisht at nokia.com wrote:
> 
> > This patch has fix for situations where variable can be NULL 
> > but not been checked beforehand.
> 
> This description doesn't seem to match the patch...
> 
> > -	if (h == NULL)
> > +	if (h)
> >  		snd_dlclose(h);
> 
> This is a coding style change, the two conditions are equivalent.

I thought too at the first glance ;)
It's the advantage of a systematic check.


Takashi


More information about the Alsa-devel mailing list