[alsa-devel] [PATCH 24/25] sound: Use static const char arrays
tiwai at suse.de
Mon Sep 13 23:33:35 CEST 2010
At Mon, 13 Sep 2010 13:47:45 -0700,
Joe Perches wrote:
> On Mon, 2010-09-13 at 22:30 +0200, Takashi Iwai wrote:
> > At Mon, 13 Sep 2010 12:48:02 -0700,
> > Joe Perches wrote:
> > > diff --git a/sound/core/misc.c b/sound/core/misc.c
> > > - char tmp = "<0>";
> > > + char tmp[sizeof("<0>")];
> > Would this case save something really...?
> Not really. It's the same x86 code size with different opcodes.
> It's just a stupid checkpatch future warning avoidance change.
> Ignore it at your pleasure.
OK, then let's postpone.
The current code is indeed not sexy, but the patch won't improve
the readability much, too ;)
More information about the Alsa-devel