[alsa-devel] [PATCH 3/5] fbdev: sh_mobile_hdmi: add new label for sound error path

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Sep 7 11:59:08 CEST 2010

On Tue, Sep 07, 2010 at 09:13:57AM +0200, Guennadi Liakhovetski wrote:
> On Tue, 7 Sep 2010, Kuninori Morimoto wrote:

> > Reported-by: Guennadi Liakhovetski <g.liakhovetski at gmx.de>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>

> You have not addressed all of my comments to your sh_mobile_hdmi.c patch 

Please do this Morimoto-san - if you wish to leave things for addressing
on a subsequent patch series then just note that in your covering mail
or similar.

> and you have not explained, why you do not address them. On the whole, I 
> am still in favour of reverting that original patch and redoing it.

It would seem like we'd make more progress if the two of you could both
work on incrementally fixing the problems with the current code rather
than blocking its inclusion totally.

More information about the Alsa-devel mailing list