[alsa-devel] [patch v3 1/2] ASoC: add support for alc562[123] codecs

[Mark Brown]

On Thu, Oct 21, 2010 at 12:44:37PM +0200, Arnaud Patard wrote:

> +static void alc5623_work(struct work_struct *work)
> +{
> +	struct snd_soc_codec *codec =
> +		container_of(work, struct snd_soc_codec, delayed_work.work);
> +	alc5623_set_bias_level(codec, codec->bias_level);
> +}

Like I said when reviewing the last version please remove this and do
the ramping of VMID in line where it's required instead - the framework
should support this well enough now.  Indeed...

> +	/* charge alc5623 caps */
> +	if (codec->suspend_bias_level == SND_SOC_BIAS_ON) {
> +		alc5623_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
> +		codec->bias_level = SND_SOC_BIAS_ON;
> +		alc5623_set_bias_level(codec, codec->bias_level);

...it looks like it may just be that the delayed work and associated
stuff is left over and can be removed entirely.