[alsa-devel] [PATCH] sound/soc: rename vol to volatile_register as appropriate
joe at perches.com
Wed Oct 13 17:27:47 CEST 2010
On Wed, 2010-10-13 at 16:11 +0100, Mark Brown wrote:
> On Wed, Oct 13, 2010 at 05:55:48AM -0700, Joe Perches wrote:
> > Looking at the 2 register access routines where
> > volatile_register/vol is used, I'd say those
> > routines aren't useful at all and the checks
> > should be inline instead.
> If you check the code again you will notice that these functons are all
> used in ops structures which presents obvious issues when trying to
> replace with open coded checks.
> I hope their usefulness is clear given the above.
There is some value in using consistent
function styles for table driven and non-table
> > > It's used as the field name for volatility in all the
> > > drivers I can remember that use a table to look volatility up in
> > > register properties.
> > I did a grep for vol in sound, I found the uses
> > where it was for volatile and patched them.
> You're missing the "for this" here, I believe. To reiterate what I said
> originally as far as I can remember every ASoC driver which uses a table
> to look up volatility uses this naming.
So all in this case means 3, 1 of which
doesn't use it. I sent patches for them.
The last patch saves ~3kb which I think
is useful for ASoC.
More information about the Alsa-devel