[alsa-devel] [RFC PATCH] sound/soc/codecs/wm8962.c: Use register index, save 100kb text
broonie at opensource.wolfsonmicro.com
Wed Oct 13 22:29:38 CEST 2010
On Wed, Oct 13, 2010 at 01:06:22PM -0700, Joe Perches wrote:
> On Wed, 2010-10-13 at 20:40 +0100, Mark Brown wrote:
> > The size impact of doing something
> > simple is a bit annoying but not usually a pressing issue on devices
> > that would want a CODEC with a noticably large register map.
> I think wasting 100+ KB is excessive if I
> were designing some cheap mp3 player.
Absolutely, but if you're desigining a cheap MP3 player you're very much
more likely to be using a much simpler device which doesn't have the
very large, sparse register maps that get a substantial benefit from
compressing the data like this. As I said, devices that would want a
CODEC with a register map that is affected usually aren't under that
much size pressure for the kernel.
> Up to you how/when it should be resolved/fixed,
> but I think it should be.
As I said in the text which you cut I agree that this should be improved
but don't want to have to go through each and every device cut'n'pasting
code since that's not going to do anything for maintainbility.
In addition to my previous comments about your subject lines for patches
please also avoid burying new patches in the middle of tangentially
More information about the Alsa-devel