[alsa-devel] [PATCH] ASoC: Add max98088 CODEC driver
broonie at opensource.wolfsonmicro.com
Wed Oct 13 12:32:24 CEST 2010
On Tue, Oct 12, 2010 at 06:20:10PM -0700, Peter Hsiang wrote:
This looks pretty good, waiting for Liam's review but I think we can do
further stuff incrementally. Minor comments:
> + /* Setup an array of texts for the equalizer enum.
> + * This is based on Mark Brown's equalizer driver code.
> + * It has been extended to support multiple equalizers.
> + */
The code that you're basing this on supports multiple equalizers too -
things like the WM8994 have several. Given that all those supported by
the original code are identical there didn't seem to be any point in
restricting which EQ a given setup can be deployed on - it's just one
more thing that can go wrong.
> +static int max98088_remove(struct snd_soc_codec *codec)
> + if (codec->control_data)
> + max98088_set_bias_level(codec, SND_SOC_BIAS_OFF);
The control_data check should be redundant here.
More information about the Alsa-devel