[alsa-devel] [PATCH v2 4/6] ARM: S5P: Add EPLL rate change warning
broonie at opensource.wolfsonmicro.com
Wed Oct 13 10:09:02 CEST 2010
On Wed, Oct 13, 2010 at 04:55:55PM +0900, Kukjin Kim wrote:
> Seungwhan Youn wrote:
> > This patch adds warning about changing EPLL rate to notice that other
> > driver that controls H/W, which is using EPLL, will has unknown effects
> > by this EPLL rate change.
> > + printk(KERN_WARNING "EPLL Rate changes from %lu to %lu\n",
> > + clk->rate, rate);
> Do we really need KERN_WARNING here?
> How about just KERN_INFO?...In my opinion, to change EPLL value seems to be
> nearer 'information' message more than 'warning'.
Personally I don't think it really makes much odds so long as the
message is displayed on the console by default.
More information about the Alsa-devel