[alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Oct 11 12:47:38 CEST 2010

On Sat, Oct 09, 2010 at 10:52:26AM +0900, Jassi Brar wrote:
> On Fri, Oct 8, 2010 at 6:07 PM, Seungwhan Youn <claude.youn at gmail.com> wrote:

> > Now, I'm almost finished 2nd patch for submit except this audio clock
> > setting. For now, I can only think that remove audio clock setting
> > from this machine code, and add audio clock settings in arch later(may
> > be after arch/arm/plat-samsung get EPLL policy as Mr. Kukjin said).

> > Is this okay?

> IMO neither of the method is much better than the other.

> If neither of the maintainers relent, maybe drop the clock setting altogether
> and mark the machine driver 'BROKEN' until the EPLL management is fixed?

I'm OK with having the code in the driver, I just want something there
that makes it more discoverable that it's there like a config option.
Having the driver log loudly when it reconfigures the EPLL would
probably also cover it.

More information about the Alsa-devel mailing list