[alsa-devel] [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio
kgene.kim at samsung.com
Wed Oct 6 08:34:47 CEST 2010
Seungwhan Youn wrote:
> >>> I hope you noticed that this clock hierarchy is a _very_ board specific thing.
> >>> We can easily place SoCs' shared stuff in arch/arm/plat-samsung (or similar)
> >>> Any suggestions, where do we place code shared by SMDK-boards ?
> >> plat-samsung would probably be fine for that also - create a file called
> >> common-smdk or something. Some other things have gone for a plat-smdk
> >> style approach too, though I'm not sure how tasteful I find that
> >> personally.
> > Even though I would personally like to have EPLL control for a device
> > in machine specific manner as part of its driver, I accept your opinion.
> > Claude, let us create one arch/arm/plat-samsung/smdk.c to do common
> > stuff for SMKDs like EPLL control. What do you think ?
> Actually if we add this file on plat-samsung, board-init will be
> separated two-part, one is machine(board) specific and other is all
> smdk specific. So, If it doesn't make confusion to other guys who
> wants to add settings for their features on board-init, it looks good
> to me. But I think that we also have to listen Mr. Ben Dooks and Mr.
> Kukjin Kim's opinion about this before we get a conclusion.
I think, basically it'd better if could control clock stuff in each driver for it when need it such as clk_get, clk_enable and so on.
Actually there is no policy/protection for EPLL usage in plat-samsung or plat-s5p now and need to sort out other similar case for it also....so in my opinion, right now to proceed with the current style is helpful to me and will consider it in the future.
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
More information about the Alsa-devel