[alsa-devel] [PATCH 5/5] ASoC: tpa6130a2: Make DAPM registration optional, and direct interface

[Mark Brown]

On Tue, Nov 30, 2010 at 04:00:04PM +0200, Peter Ujfalusi wrote:
> Users can choose to not add the DAPM routes provided by the
> amp driver, but use the direct enable/disable interface
> from machine driver with SND_SOC_DAPM_HP's event callback.
> In some cases this method must be used to make the audio
> path pop noise free.

Is there any situation where it would undesirable to do this?  If not
it'd seem better to just make the driver do this always.

> +int tpa6130a2_stereo_enable(int enable)
> +{

It'd be much nicer if this took a CODEC as an argument - even if the
implementation doesn't actually use it yet it'd be better to have an
interface which has an idea that there may be multiple instances of the
device.