[alsa-devel] [PATCH 1/7] ASoC: i.MX31ads: initialize only on correct machine

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Nov 5 14:09:42 CET 2010

On Fri, Nov 05, 2010 at 10:16:24AM +0100, Sascha Hauer wrote:
> On Thu, Nov 04, 2010 at 02:51:36PM -0400, Mark Brown wrote:

> > As previously discussed we need a better check than this - most of these
> > machines won't have a 1133-EV1 PMIC module on them.  Better to convert
> > the driver to instantiate from a platform device...

> This does not solve the problem as we do not know when to register the
> platform_device. I think what we need is a kernel parameter which can be
> used to select the correct path in arch/arm/mach-mx3/mach-mx31ads.c

It can be registered in the callback that's called immmediately after
the WM835x is probed on the machine driver.

> aswell. I will look into it. For now, can we just take this patch? It
> at least fixes all other i.MX31 boards and leaves only the mx31ads to
> work on.

I'd much rather get it fixed properly - it's not so urgent since it
really only only affects allyesconfig or allmodconfig type stuff with
people explicitly loading the driver.

More information about the Alsa-devel mailing list