[alsa-devel] [PATCH 1/2] pcm: pass hw_params flags to slave
bossart.nospam at gmail.com
Tue Nov 2 13:52:58 CET 2010
Thanks Takashi for the review.
> I'm a bit skeptical whether this is safe to apply.
> The plugins might not be always transparent. Double-check whether
> this doesn't break all plugins behaviors.
I am really not sure how I can prove that passing flags does not alter
existing behavior, I identified this issue experimentally after
several hours and I must admit I don't really understand the alsa-lib
The question is really why weren't the flags propagated in the initial
code? All parameters (info, rate, etc) are passed to the slave, except
the flags. Either this was a conscious design decision, in which case
my patch would create a problem, or this was a miss and my patch
>> params->info &= src->info;
>> + params->flags = src->flags; /* propagate flags to slave */
More information about the Alsa-devel