[alsa-devel] [PATCH 2/2] add API to allow disabling period interrupt

[Jaroslav Kysela]

On Tue, 2 Nov 2010, Clemens Ladisch wrote:

> Jaroslav Kysela wrote:
>> On Tue, 2 Nov 2010, Clemens Ladisch wrote:
>>>> + * It is not allowed to call this function when given configuration is not exactly one.
>>>> ...
>>>> +int snd_pcm_hw_params_can_disable_period_irq(const snd_pcm_hw_params_t *params)
>>>
>>> This function is useless because it cannot be called before
>>> snd_pcm_hw_params_set_period_irq().
>>
>> I don't think so. The info bits from the driver are used in this check
>> which are read-only.
>
> All the snd_pcm_hw_params_can_* functions that read the info bits
> are documented to require a completed configuration.  So they actually
> don't, and there will never be a flag that depends on the configuration?

You're right. The *_can_* check should be removed.

 						Jaroslav

-----
Jaroslav Kysela <perex at perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.