[alsa-devel] [PATCH] ALSA/davinci: Use the resource_size , __devinit and __devexit.

Sergei Shtylyov sshtylyov at mvista.com
Fri May 28 15:33:15 CEST 2010


Wan ZongShun wrote:

> Dear all,

> Use the resource_size function instead of manually calculating the
> resource size.  This reduces the chance of introducing off-by-one
> errors.

> In addition, to use __devinit and __devexit is good too.

    "Good" isn't a good justification I think.
    Also, this just asks to be put into two patches instead of one as 
the patch does two completely different things.

> Signed-off-by:Wan ZongShun<mcuos.com at gmail.com>

WBR, Sergei

More information about the Alsa-devel mailing list