[alsa-devel] [PATCH] ALSA: hda: Fix model quirk for Dell M1730

[Takashi Iwai]

At Sun, 23 May 2010 20:56:16 -0400,
Daniel Chen wrote:
> 
> Hi,
> 
> Attached please find a patch for sound-2.6 master HEAD that fixes
> capture out-of-the-box for Dell M1730.
> 
> This patch is applicable to all 2.6.32, 2.6.33, and 2.6.34 stable trees.

Applied this one, too.  Thanks.


Takashi

> 
> Best,
> -Dan
> [2 0001-ALSA-hda-Fix-model-quirk-for-Dell-M1730.patch <text/x-patch; US-ASCII (base64)>]
> From 68f4145419ece05ec2bbc7cf91db433793e57e02 Mon Sep 17 00:00:00 2001
> From: Daniel T Chen <crimsun at ubuntu.com>
> Date: Sun, 23 May 2010 20:47:45 -0400
> Subject: [PATCH] ALSA: hda: Fix model quirk for Dell M1730
> 
> BugLink: https://launchpad.net/bugs/576160
> 
> Symptom: Currently (2.6.32.12) the Dell M1730 uses the 3stack model
> quirk. Unfortunately this means that capture is not functional out-
> of-the-box despite ensuring that capture settings are unmuted and
> raised fully.
> 
> Test case: boot from Ubuntu 10.04 LTS live cd; capture does not
> work.
> 
> Resolution: Correct the model quirk for Dell M1730 to rely on the
> BIOS configuration.
> 
> This patch also trivially sorts the quirk into the correct section
> based on the comments.
> 
> Reported-and-Tested-By: <picdragon99 at msn.com>
> Tested-By: Daren Hayward
> Tested-By: Tobias Krais
> Cc: <stable at kernel.org>
> Signed-off-by: Daniel T Chen <crimsun at ubuntu.com>
> ---
>  sound/pci/hda/patch_sigmatel.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index a0e06d8..f1e7bab 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -2078,12 +2078,12 @@ static struct snd_pci_quirk stac927x_cfg_tbl[] = {
>  	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_INTEL, 0xff00, 0x2000,
>  			   "Intel D965", STAC_D965_3ST),
>  	/* Dell 3 stack systems */
> -	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL,  0x01f7, "Dell XPS M1730", STAC_DELL_3ST),
>  	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL,  0x01dd, "Dell Dimension E520", STAC_DELL_3ST),
>  	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL,  0x01ed, "Dell     ", STAC_DELL_3ST),
>  	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL,  0x01f4, "Dell     ", STAC_DELL_3ST),
>  	/* Dell 3 stack systems with verb table in BIOS */
>  	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL,  0x01f3, "Dell Inspiron 1420", STAC_DELL_BIOS),
> +	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL,  0x01f7, "Dell XPS M1730", STAC_DELL_BIOS),
>  	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL,  0x0227, "Dell Vostro 1400  ", STAC_DELL_BIOS),
>  	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL,  0x022e, "Dell     ", STAC_DELL_BIOS),
>  	SND_PCI_QUIRK(PCI_VENDOR_ID_DELL,  0x022f, "Dell Inspiron 1525", STAC_DELL_BIOS),
> -- 
> 1.7.0.4
>