[alsa-devel] [PATCH 1/1] ALSA: usb-audio: add support for Akai MPD16

Clemens Ladisch clemens at ladisch.de
Thu May 20 11:21:54 CEST 2010


Krzysztof Foltman wrote:
> What about the oversized comment block about MPD16 SysEx messages -
> should it remain in the source file, or should I move it to a text file
> or remove it altogether?

The comments in this file are usually only about the protocol itself,
because this is what the driver needs to know.  The fact that all
SysEx's have a known limit of 9 bytes is interesting for the driver,
but the contents of the SysEx messages are important only to programs
that want to control the MPD16; I'm not sure if this even belongs into
the kernel.  (In theory, this comment belongs into that control
application.)


Regards,
Clemens


More information about the Alsa-devel mailing list