[alsa-devel] [PATCH 1/1] ALSA: usb-audio: add support for Akai MPD16
wdev at foltman.com
Tue May 18 20:36:42 CEST 2010
On 05/18/2010 01:38 AM, Daniel Mack wrote:
> Just a minor coding style flaw here for the curly brackets. See
> Documentation/CodingStyle or let scripts/checkpatch.pl annoy you :)
Fixed, I'll resend it ASAP. The awkward part is that checkpatch.pl also
complains about the use of space after the ampersand in quirks-table.h,
where it seems to be a common practice. The CodingStyle document does
mention unary &, but it doesn't mention this sort of initialization syntax.
> FWIW, I think the block above could also be a for-loop, but that's
> certainly a matter of taste.
I wouldn't use a for statement with this longish condition - it would no
more readable than separate init/condition/increment with a while loop.
More information about the Alsa-devel