[alsa-devel] [PATCH 1/3] add API to allow disabling period interrupts

pl bossart bossart.nospam at gmail.com
Mon May 17 15:59:21 CEST 2010


Looks good. Using the .info field is probably better than adding a new
one as I did. One correction though:

> +       runtime->no_period_irq =
> +                       !!(params->flags & SNDRV_PCM_HW_PARAMS_NO_PERIOD_IRQ);

An additional test is needed here so that the capabilities of the
hardware are double-checked

if (params->info & SNDRV_PCM_INFO_NO_PERIOD_IRQ)
     runtime->no_period_irq = !!(params->flags &
SNDRV_PCM_HW_PARAMS_NO_PERIOD_IRQ);
else
    runtime->no_period_irq = 0;


More information about the Alsa-devel mailing list