[alsa-devel] [patch 5/6] orion/kirkwood: Add i2s support

Mark Brown broonie at opensource.wolfsonmicro.com
Sun May 16 19:31:09 CEST 2010

On Sat, May 15, 2010 at 05:30:03PM +0200, apatard at mandriva.com wrote:

> This patch enables support for the i2s controller available on orion/kirkwood platforms
> Signed-off-by: Arnaud Patard <apatard at mandriva.com>

All looks sensible enough, CCing in Liam.  One thing...

> +	if (status & ~(ORION_INT_CAUSE_PLAY_BYTES | \
> +		printk(KERN_WARNING "%s: unexpected interrupt %lx\n",
> +			__func__, status);
> +		return IRQ_HANDLED;
> +	}

Did the driver really handle the interrupt here?  It's not even written
an ack back so IRQ_NONE might be a better response (the problem with
using IRQ_NONE before was that the driver may have handled some transfer
interrupts before it got the empty status).

More information about the Alsa-devel mailing list