[alsa-devel] [PATCHv2] ASoC: tlv320aic3x: Add platform data and reset gpio handling

Peter Ujfalusi peter.ujfalusi at nokia.com
Thu May 6 10:09:34 CEST 2010

On Wednesday 05 May 2010 13:02:03 ext Jarkko Nikula wrote:
> Signed-off-by: Jarkko Nikula <jhnikula at gmail.com>
> ---
> v2:
> - Removed added regulator_bulk_disable brain fart from aic3x_i2c_probe
> - Added comment to gpio_reset number in aic3x_pdata

Would have been nice to have a commit message for this just in case.
Something like this would do:
Handle the reset GPIO within the codec driver in order to follow the startup 
protocol for the tlv320aic3x codecs.

Can you Liam add this message (if Jarkko agrees)?

I can give my:
Acked-by: Peter Ujfalusi <peter.ujfalusi at nokia.com>
Reviewed-by: Peter Ujfalusi <peter.ujfalusi at nokia.com>

Whichever you feel appropriate in case of the tlv320aic3x codec driver.


More information about the Alsa-devel mailing list