[alsa-devel] [PATCH] ASoC: tlv320aic3x: Add platform data and reset gpio handling

Jarkko Nikula jhnikula at gmail.com
Wed May 5 11:50:20 CEST 2010


On Wed, 5 May 2010 12:35:55 +0300
Peter Ujfalusi <peter.ujfalusi at nokia.com> wrote:

> >  err_enable:
> >  	regulator_bulk_free(ARRAY_SIZE(aic3x->supplies), aic3x->supplies);
> >  err_get:
> > +	regulator_bulk_disable(ARRAY_SIZE(aic3x->supplies), aic3x->supplies);
> 
> This looks suspicious (disable after free?)
> On the other hand, is there a need to disable at all in error case?
> 
Oops. How that went there. Thanks for noticing!


-- 
Jarkko


More information about the Alsa-devel mailing list