[alsa-devel] [PATCH] ASoC: omap: Add basic audio support for Nokia RX-51/N900

[Jarkko Nikula]

On Wed, 5 May 2010 09:30:22 +0300
Peter Ujfalusi <peter.ujfalusi at nokia.com> wrote:

> Also, tlv320aic3x driver will try to set the defaults to the codec during the 
> i2c probing. I'm not sure, but if the reset line is low at that point it may 
> cause problems (reset line is low, and the reset sequence has not been 
> followed).
> Than later in the machine driver the chip is taken out from reset, which might 
> means, that the chip will be in reset state, so the initial configuration done 
> by the codec driver might be lost.
> 
> I think it would be better to handle the reset GPIO within the codec driver at 
> the end for proper operation.
> 
> What do you think?
> 
Thanks! Definitely reset handling is better to move to codec driver.
Especially important if starting to manage digital voltages there. I'll
cook up updated versions.


-- 
Jarkko