[alsa-devel] [PATCH] ASoC: Fix passing platform_data to ac97 bus users and fix a leak.

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Mar 25 17:09:32 CET 2010

On Thu, Mar 25, 2010 at 10:52:12AM +1030, Graham Gower wrote:
> Mark, Liam,
> As requested, this patch removes the initial allocation of codec->ac97.

Please recheck SubmittingPatches - this'd end up in the changelog (and
now your changelog is empty so it's not clear what the actual problem is
any more).  I've applied this with a changelog added and...

>  		}
> -		if (card->dai_link[i].codec_dai->ac97_control) {
> +		if (card->dai_link[i].codec_dai->ac97_control && codec->ac97) {
>  			snd_ac97_dev_add_pdata(codec->ac97,
>  				card->dai_link[i].cpu_dai->ac97_pdata);

...a comment here since otherwise it's not obvious why we're not
complaining about the missing codec->ac97 otherwise.

More information about the Alsa-devel mailing list