[alsa-devel] [PATCH 11/20] ASoC: SAMSUNG: I2S: Add bit definitions

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Mar 10 13:56:22 CET 2010


On Wed, Mar 10, 2010 at 09:49:03PM +0900, jassi brar wrote:
> On Wed, Mar 10, 2010 at 9:38 PM, Mark Brown

> > I agree that this is the only really controversial change, but it seemed
> > like pretty much all the changes that added stuff to the headers or used
> > them could've been done pre-move so that they didn't depend on it.

> Not sure which patch you point, but it was decision of logical
> build-up and successful
> compilation after each patch that made the patch series as it is now.

Pretty much all of them - for example, patch 11 adds a bunch of new
bitfield definitions to the header.  This change didn't really need the
header to have been moved before it was made, it could have been done
pre-move.  Keeping things building is important and some of the changes
that affected both S3C24xx and S3C64xx might've needed the move for that
but not all of them.


More information about the Alsa-devel mailing list