[alsa-devel] [PATCH 04/20] ASoC: S3C: I2Sv2: Remove S3C_IIS_V2_SUPPORTED define

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Mar 10 11:49:13 CET 2010

On Wed, Mar 10, 2010 at 04:48:53PM +0900, Jassi Brar wrote:
> The code in s3c-i2s-v2.c is compiled via Makefile and not implicitly
> by include'ing. Also, the driver developer anyways has to refer to the
> manual to see if the code can be reused for the SoC under consideration.
> That makes the S3C_IIS_V2_SUPPORTED retrospective rather than a check.

> Signed-off-by: Jassi Brar <jassi.brar at samsung.com>

This code is in there for pure defensiveness - since at least the
S3C64xx and S3C24xx have slightly different register maps for the block
(the ones that are currently handled are the IISMOD master settings,
there may be more) the code needs to have explicit support for the
processors.  The goal of this block is to print a #error saying exactly
what's going on rather than just have the build fail with missing
defines in order to help make it more immediately clear to users what is
going on if they try to select a processor combination they don't know
how to handle.  

Users often have a strong expectation that the driver will just work
and so relying on them consulting the processor manual isn't always

It may be that these differences are due to some being IISv2 and some
being IISv3 or something and could easily be handled via mandatory
platform data but since none of the documentation refers to any of this
stuff and it has to be reverse engineered we've got this system based on
build time processor selection.

More information about the Alsa-devel mailing list