[alsa-devel] [PATCH 02/20] ASoC: S3C: I2Sv2: Reject immidiate register value

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Mar 10 11:32:04 CET 2010

On Wed, Mar 10, 2010 at 04:48:51PM +0900, Jassi Brar wrote:
> Towards generalizing CPU driver interface, do not accept direct field
> values for the BCLK and RCLK.
> The machine driver should simply request the FS-multiple and not provide
> the value to be set in divide field of IISMOD.

> Signed-off-by: Jassi Brar <jassi.brar at samsung.com>

This is good but it needs to also update all the machine drivers that
use the direct register values.  A brief grep through suggests that the
uda134x machine and the OpenMoko machines need a look, though I didn't
actually check which DAI driver they're all using.  If nothing uses this
feature then just note that in the changelog (if the feature is unused
that's even more reason to remove it anyway).

More information about the Alsa-devel mailing list