[alsa-devel] [PATCH 3/5] ASoC: DaVinci: CQ93VC Voice Codec

[Mark Brown]

On 8 Mar 2010, at 17:26, Miguel Aguilar <miguel.aguilar at ridgerun.com>  
wrote:

Please don't top post.

> What is the status of this patch series?, I'm still missing the  
> change pointed below for third patch.

It's waiting for someone to post a version with that change made.

> Mark Brown wrote:
>> On Thu, Jan 21, 2010 at 11:41:00AM -0600,  
>> miguel.aguilar at ridgerun.com wrote:
>>> +static __init int cq93vc_codec_probe(struct platform_device *pdev)
>>> +{
>> ...
>>> +    cq93vc_codec = codec;
>>> +
>>> +    ret = snd_soc_register_dai(&cq93vc_dai);
>>> +    if (ret != 0) {
>>> +        dev_err(davinci_vc->dev, "could register dai\n");
>>> +        goto fail1;
>>> +    }
>>> +    return 0;
>> There should also be a snd_soc_register_codec() before this, and
>> similarly on the remove.  Otherwise this looks good.

Like I say, the codec needs to be registered as well, not just the  
DAIs. Please refer to other codec drivers for examples.