[alsa-devel] [PATCH] ASoC: Add delay information for Samsung IISv2 DAIs

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Mar 4 14:24:17 CET 2010


On Thu, Mar 04, 2010 at 10:18:59PM +0900, jassi brar wrote:
> On Thu, Mar 4, 2010 at 9:05 PM, Mark Brown

> > +static long s3c2412_i2s_delay(struct snd_pcm_substream *substream,
> > + ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ?? ??struct snd_soc_dai *dai)

> return type snd_pcm_sframes_t ?

Meh, yeah.  It's actually the same type underneath.

> I am trying to make functions in s3c-i2s-v2.c re-entrant as much as possible,
> 'delay' too seems to be a good candidate.

Could you expand on what you mean by this?  All we're doing here is
directly reporting a value read from a memory mapped register so there's
nothing to be worried about from a locking point of view unless there
were a multi-core system and the bus to the IP needed some locking,
which is vanishingly unlikely to ever happen.


More information about the Alsa-devel mailing list