[alsa-devel] [PATCH 1/3] ALSA: usb: move ua101 driver

Takashi Iwai tiwai at suse.de
Mon Mar 1 15:06:57 CET 2010

At Mon, 1 Mar 2010 15:01:29 +0100,
Daniel Mack wrote:
> On Mon, Mar 01, 2010 at 12:27:31PM +0100, Clemens Ladisch wrote:
> > Daniel Mack wrote:
> > > As part of the USB audio code cleanup, move the non-standard ua101
> > > driver out of the way.
> > 
> > A directory with a single source file in it isn't quite an improvement.
> > Please name it "misc" so that other specialized drivers could be put in
> > there.
> Ok, will do. However, I wonder which way is best to do that. Given that
> you posted patches on top of mine, can I take this as a general
> agreement to my changeset? If so, I will just provide a patch on top to
> do the ua101 -> misc rename, because otherwise, I would have to rebase
> all three patches for that.

Well, honestly, I prefer seeing the fixes by Clemens based on the
current code, and merge Daniel's refactoring patches after 2.6.34
merge window. 

Refactoring is a good thing but it can easily introduce any careless
bugs (like copy&paste error), and this split action makes really hard
to track the changes.  Thus I'd like to keep this well ripened before
reaching to the Linus tree, not only for a few days.



More information about the Alsa-devel mailing list