[alsa-devel] [RFC 04/16] ASoC: multi-component - TI CODECs

peter.ujfalusi at nokia.com peter.ujfalusi at nokia.com
Wed Jun 30 14:08:11 CEST 2010

Hello Liam,

I'm on holiday, and I have limited access to e-mail, but I did taken a brief look at the series..
I have few question:
Is the support for the former codec->idle_bias_off is gone? This patch removes it from the
tlv320dac33, and t2l4030 codec drivers.
I'm not really sure about the restructure of the tlv320dac33 driver:
- The codec ID register read has been removed, which is really useful, and it is going to be
  used to enable/disable features of DAC33 based on the ID.
- Originally the codec was off by default, now it is on all the time.
- What is the reason to move the IRQ, GPIO, and regulator request from the i2c_probe to soc_probe?

Some of these valid for the twl4030 codec as well (especially the idle_bias_off support).

I don't claim, that I have checked all the patches, and changes, but at least with the tlv320dac33,
and twl4030 codec drivers I can see some unwanted (for me) PM related regressions.
Are these removals intentional?

From: alsa-devel-bounces at alsa-project.org [alsa-devel-bounces at alsa-project.org] On Behalf Of ext Liam Girdwood [lrg at slimlogic.co.uk]
Sent: Friday, June 25, 2010 8:52 PM
To: alsa-devel at alsa-project.org
Cc: Mark Brown; Liam Girdwood
Subject: [alsa-devel] [RFC 04/16] ASoC: multi-component - TI CODECs

Move TI CODECs to multi-component

This patch changes the probe() and remove() of the CODEC drivers as follows:-

 o Make CODEC driver a platform device (non MFD codecs only)
 o Moved all struct snd_soc_codec list, mutex, etc initialiasation to core.
 o Removed all static codec pointers (drivers now support > 1 codec dev)
 o snd_soc_register_pcms() now done by core.
 o snd_soc_register_dai() folded into snd_soc_register_codec().
 o codec cache can now be malloc()ed by core.

Other required changes due to multi-component model :-

 o tlv320aic3x: no more "setup_data" from ASoC machine drivers, platform data
 must be set in one place only. Moved platform defs out into platorm header.

More information about the Alsa-devel mailing list