[alsa-devel] [PATCH RFC 1/3] ASoC: uda1380: use callbacks instead of gpiolib

Vasily Khoruzhick anarsoul at gmail.com
Sat Jun 26 23:12:05 CEST 2010


В сообщении от 26 июня 2010 23:57:42 автор Mark Brown написал:

> You definitely should be doing this in the I2C driver not the CODEC driver,
> you're peering inside the internals of the I2C driver as things stand and
> are likely to cause problems if someone comes along and implements this in
> the driver. There's also the fact that all users of the I2C controller
> will benefit if the code is implemented there, not just this one audio
> driver.

I'm afraid that it can cause problems with other i2c-controlled devices, and I 
can test i2c modification only on h1940 and rx1950 with same codec (uda1380).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20100627/15e0ca23/attachment.sig 


More information about the Alsa-devel mailing list