[alsa-devel] [PATCH] soc/imx: clean Kconfig

[Eric Bénard]

Hi Mark,

Le 19/06/2010 10:47, Eric Bénard a écrit :
> Signed-off-by: Eric Bénard<eric at eukrea.com>
>
> Cc: lrg at slimlogic.co.uk
> Cc: broonie at opensource.wolfsonmicro.com
> Cc: s.hauer at pengutronix.de
> ---
>   sound/soc/imx/Kconfig |   14 ++++++--------
>   1 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/sound/soc/imx/Kconfig b/sound/soc/imx/Kconfig
> index 6ef57e0..2f0d6d3 100644
> --- a/sound/soc/imx/Kconfig
> +++ b/sound/soc/imx/Kconfig
> @@ -1,4 +1,4 @@
> -config SND_IMX_SOC
> +menuconfig SND_IMX_SOC
>   	tristate "SoC Audio for Freescale i.MX CPUs"
>   	depends on ARCH_MXC
>   	select SND_PCM
> @@ -8,14 +8,12 @@ config SND_IMX_SOC
>   	  Say Y or M if you want to add support for codecs attached to
>   	  the i.MX SSI interface.
>
> -config SND_MXC_SOC_SSI
> -	tristate
> +if SND_IMX_SOC
>
>   config SND_MXC_SOC_WM1133_EV1
>   	tristate "Audio on the the i.MX31ADS with WM1133-EV1 fitted"
> -	depends on SND_IMX_SOC&&  MACH_MX31ADS_WM1133_EV1&&  EXPERIMENTAL
> +	depends on MACH_MX31ADS_WM1133_EV1&&  EXPERIMENTAL
>   	select SND_SOC_WM8350
> -	select SND_MXC_SOC_SSI
>   	help
>   	  Enable support for audio on the i.MX31ADS with the WM1133-EV1
>   	  PMIC board with WM8835x fitted.
> @@ -23,17 +21,17 @@ config SND_MXC_SOC_WM1133_EV1
>   config SND_SOC_PHYCORE_AC97
>   	tristate "SoC Audio support for Phytec phyCORE (and phyCARD) boards"
>   	depends on MACH_PCM043 || MACH_PCA100
> -	select SND_MXC_SOC_SSI
>   	select SND_SOC_WM9712
>   	help
>   	  Say Y if you want to add support for SoC audio on Phytec phyCORE
>   	  and phyCARD boards in AC97 mode
>
>   config SND_SOC_EUKREA_TLV320
> -	bool "Eukrea TLV320"
> +	tristate "Eukrea TLV320"
>   	depends on MACH_EUKREA_MBIMX27_BASEBOARD || MACH_EUKREA_MBIMXSD_BASEBOARD
> -	select SND_IMX_SOC
>   	select SND_SOC_TLV320AIC23
>   	help
>   	  Enable I2S based access to the TLV320AIC23B codec attached
>   	  to the SSI4 interface
> +
> +endif	# SND_IMX_SOC

is this patch OK or should I rework it ?

Thanks,
Eric